As incomes rise, so does spending on gyms, gadgets and supplements. Young professionals now allocate up to 25% of their pay to fitness—blurring the line between discipline and lifestyle creep.